Skip to content

feat: Disable local dev startup hook & enhance preview URL display - #332

Merged
sylvansys merged 1 commit into
mainfrom
331-feature/can-u-please-deregister-the-startup-hook
Jan 29, 2026
Merged

feat: Disable local dev startup hook & enhance preview URL display#332
sylvansys merged 1 commit into
mainfrom
331-feature/can-u-please-deregister-the-startup-hook

Conversation

@sylvansys

@sylvansys sylvansys commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Disable Docker/Supabase/dev server startup hook by moving to _disabled_hooks section (preserved for future re-enabling)
  • Add formatGroupedPreviews() shared function for consistent preview URL formatting
  • Update PR hook to show ALL preview URLs grouped by provider (Vercel, Cloudflare, Supabase)

Test plan

  • Start a new Claude session - verify Docker/Supabase are NOT started
  • Verify other SessionStart hooks still run (setup-nodes-config, install-vercel, etc.)
  • Create a PR with gh pr create - verify all preview URLs are shown grouped by provider
  • End a session with open PR - verify stop hook still shows grouped previews

Closes #331

🤖 Generated with Claude Code

@sylvansys @claude
feat: Disable local dev startup hook & enhance preview URL display
d4cd3f3 
- Disable Docker/Supabase/dev server startup hook (install-start-supabase-next.ts)
  and cleanup hook (cleanup-supabase-session.ts) by moving to _disabled_hooks section
- Add formatGroupedPreviews() function to ci-status.ts for consistent preview
  URL formatting across hooks
- Update await-pr-status.ts to show ALL preview URLs (Vercel, Cloudflare,
  Supabase) grouped by provider instead of just first Vercel URL

Closes #331

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@constellos

constellos Bot commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Constellos Review - PR feedback from your reviewer agents.

Requirements: ❌ 0 • ❌ 0 • ⏭️ 0

View agent prompt

Code Quality: ✅ 4 • ❌ 0 • ⏭️ 0

View agent prompt

Check Status Reasoning
undefined ✅ No unnecessary code duplication found. The ci-status.ts module consolidates shared CI checking logic that was previously duplicated in multiple hooks. All utility functions (execCommand, getCurrentCIChecks, awaitCIWithFailFast, extractAllPreviews) are well-factored and reusable. The await-pr-status.ts hook properly imports and uses these shared utilities rather than reimplementing them.
undefined ✅ No speculative features or over-engineering detected. All functions serve concrete, documented use cases. The ci-status.ts module provides CI checking utilities actively used by multiple hooks (SubagentStop, PostToolUse, Stop). The extensive interface definitions and utility functions (checking conflicts, branch sync, extracting previews from multiple providers) are all utilized. Settings and hooks configuration are minimal and purposeful.
undefined ✅ Excellent separation of concerns. CI utilities are properly extracted to a shared module (ci-status.ts) with clear single responsibilities: command execution, PR checking, CI waiting, preview URL extraction, and formatting. The await-pr-status.ts hook focuses solely on PostToolUse orchestration and delegates to shared utilities. Configuration files (settings.json, hooks.json) follow their respective schemas without mixing concerns. Each function has clear inputs/outputs with comprehensive TypeScript types.
undefined ✅ Code is clear, well-structured, and maintainable. Comprehensive JSDoc documentation on all exported functions with examples. Descriptive variable names (headSha, prNumber, groupedPreviews). Consistent error handling patterns with typed error objects. TypeScript interfaces provide clear contracts. The ci-status.ts module is well-organized with logical sections (marked by comments). Constants are defined at module level (MAX_OUTPUT_CHARS, DEFAULT_TIMEOUT_MS). Hook configuration is self-documenting with description fields.

@sylvansys
sylvansys merged commit d629afc into main Jan 29, 2026
7 checks passed
@sylvansys
sylvansys deleted the 331-feature/can-u-please-deregister-the-startup-hook branch January 29, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plan: Disable Local Dev Startup Hook & Enhance Preview URL Display

1 participant

@sylvansys